Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move one or more TSC members to emeritus #40908

Closed
wants to merge 1 commit into from
Closed

meta: move one or more TSC members to emeritus #40908

wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/find-inactive-tsc.yml.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 21, 2021
@Trott
Copy link
Member

Trott commented Nov 21, 2021

Pinging @codebytere and @gabrielschulhof in case in case there is an error here somewhere.

codebytere last attended a TSC meeting in September 2020. gabrielschulhof last attended a TSC meeting in May 2021. Neither have participated in recent votes. So the job flagged them for removal per the requirements in the TSC Charter. The TSC Charter indicates that removal is automatic. So barring an error in the job that generated this PR, this PR must land or else we are in violation of the charter. (That said, there's nothing preventing the TSC from immediately voting to reinstate one or both members if that is the consensus of the group.)

@Trott
Copy link
Member

Trott commented Nov 21, 2021

@nodejs/tsc

@jasnell
Copy link
Member

jasnell commented Nov 21, 2021

I'm thinking we should revisit the "automatic" part of that. Having the tool open these PRs is great, but I think the removal should only become final once the PR is accepted and lands.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 21, 2021
@Trott
Copy link
Member

Trott commented Nov 21, 2021 •
edited
Loading

I'm thinking we should revisit the "automatic" part of that. Having the tool open these PRs is great, but I think the removal should only become final once the PR is accepted and lands.

I think that's implicit. It's why the PR doesn't get merged automatically and it's why we're going over the reasons for removal.

I think doing *anything* to soften the automatic nature of the removal will be a disservice. We are so so very very bad at this. The automatic removal clause has been in there for years, and there have been multiple cases where it should have tripped, and it actually only did once, and then only after two years had passed.

My point is that avoiding reviewing the PR (because, as we've seen over the years, no one likes to propose or approve these things) is a dereliction of charter mandates.

Trott
Trott approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Barring an error in the attendance/voting records, it seems like this is straightforward. Gabriel and Shelley did and continue to do great work for Node.js and the ecosystem. And I would love to have either of them back on the TSC when they have the time and inclination for TSC-specific work. (And if the TSC is not where they want to spend their time, I understand that too!)

@targos
Copy link
Member

targos commented Nov 21, 2021

Could we also automate the text that you did in #40908 (comment)?

@Trott
Copy link
Member

Trott commented Nov 21, 2021

Could we also automate the text that you did in #40908 (comment)?

Something like that should be pretty easy, yes. Let me see what I can do.

tniessen
tniessen approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gabriel and Shelley did and continue to do great work for Node.js and the ecosystem. And I would love to have either of them back on the TSC when they have the time and inclination for TSC-specific work. (And if the TSC is not where they want to spend their time, I understand that too!)

+1 to what @Trott said.

@Trott Trott mentioned this pull request Nov 21, 2021
Merged
mcollina
mcollina approved these changes Nov 21, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mhdawson
mhdawson approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MylesBorins
MylesBorins approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 great work.

I think we need to have a way to ensure that folks are properly notified when this happens.

We also need to review the counts and make sure that after something like this lands we don't have issues with the corporate representation.

@mhdawson
Copy link
Member

I think this is probably read to land. It's been a week, there are no objections and 12 TSC approvals.

I don't think this triggers any corporate representation limits, we'd be down to 20 TSC members, 25% of that being 5.

I know that everybody affected by the PR is aware.

@Trott would would you like to land?

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2021
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2021
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/40908
✔  Done loading data for nodejs/node/pull/40908
----------------------------------- PR info ------------------------------------
Title      meta: move one or more TSC members to emeritus (#40908)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/inactive-tsc -> nodejs:master
Labels     doc, meta
Commits    1
 - meta: move one or more TSC members to emeritus
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/40908
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Matteo Collina 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Beth Griggs 
Reviewed-By: Michael Dawson 
Reviewed-By: Myles Borins 
Reviewed-By: Danielle Adams 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40908
Reviewed-By: Rich Trott 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Matteo Collina 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Beth Griggs 
Reviewed-By: Michael Dawson 
Reviewed-By: Myles Borins 
Reviewed-By: Danielle Adams 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 21 Nov 2021 16:10:55 GMT
   ✔  Approvals: 12
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-811942760
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-811944177
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-811957705
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-811959382
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-811963474
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-811964693
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-811972714
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-812163400
   ✔  - Beth Griggs (@BethGriggs) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-812422557
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-813956571
   ✔  - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-814166929
   ✔  - Danielle Adams (@danielleadams) (TSC): https://github.com/nodejs/node/pull/40908#pullrequestreview-817150279
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1517006065

@nodejs-github-bot @Trott
meta: move one or more TSC members to emeritus
610696a 
PR-URL: #40908
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 29, 2021

Landed in 610696a

@Trott Trott closed this Nov 29, 2021
@Trott Trott deleted the actions/inactive-tsc branch November 29, 2021 17:03
richardlau pushed a commit to nodejs/email that referenced this pull request Nov 29, 2021
@Trott
chore: update tsc and crypto-export mailing lists (#177)
e77faef 
Reflect TSC membership changes in tsc and crypto-export mailing lists.

Refs: nodejs/node#40908
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@nodejs-github-bot @danielleadams
meta: move one or more TSC members to emeritus
614922f 
PR-URL: #40908
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@nodejs-github-bot @danielleadams
meta: move one or more TSC members to emeritus
f30d6bc 
PR-URL: #40908
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@nodejs-github-bot @danielleadams
meta: move one or more TSC members to emeritus
88e27fa 
PR-URL: #40908
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@nodejs-github-bot @danielleadams
meta: move one or more TSC members to emeritus
714efe4 
PR-URL: #40908
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Johnhvy added a commit to Johnhvy/NodeJS-Email that referenced this pull request Jul 16, 2024
@Johnhvy
chore: update tsc and crypto-export mailing lists (#177)
fa540b5 
Reflect TSC membership changes in tsc and crypto-export mailing lists.

Refs: nodejs/node#40908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@danielleadams danielleadams danielleadams approved these changes

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.